#18356: special resultants ``composed_sum`` and ``composed_product``
-------------------------------------+-------------------------------------
Reporter: pernici | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.7
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/pernici/ticket/18356 | 3806e8403764abf4d391161f836f0ec422201cc5
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
I had a look at the branch, just some comment
1. It is better to use `Return XYZ` rather than `Compute XYZ` in the one
line description of functions. What the function is internally doing is
mostly a technical question. What you want to know when reading the
documentation is what does the function return.
2. This is old cython
{{{
cdef int i
for i from 0 <= i <= n:
...
}}}
you can just write
{{{
cdef int i
for i in range(n):
...
}}}
this will be transformed into a C loop by Cython.
3. In `hadamard_product` I would defined precisely what is the pointwise
product. If you have a naive look to wikipedia, the pointwise product of
two functions `f` and `g` is just `x -> f(x)g(x)`.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18356#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
