#18409: Dynatomic polynomial bug for fractional coefficients
-------------------------------------+-------------------------------------
       Reporter:  gjorgenson         |        Owner:  bhutz
           Type:  defect             |       Status:  needs_work
       Priority:  minor              |    Milestone:  sage-6.7
      Component:  algebraic          |   Resolution:
  geometry                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Ben Hutz           |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  e777520afbd36613e52df9ed04144efc5cb4d0c6
  u/bhutz/ticket/18409               |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Hi Ben,

 Replying to [comment:9 bhutz]:
 > For the examples, I wasn't sure about adding them.

 It will be very useful to detect regression. You can add something along
 {{{
 TESTS:

 We check that for some delicate polynomial ring, the dynatomic polynomial
 has
 the right parent (see :trac:`18409`)::

     sage: p1 = my_example1
     sage: parent(p1)
     ...

     sage: p2 = my_example2
     sage: parent(p2)
     ...

 Though, this one still does not work::

     sage: p3 = my_example3
     sage: parent(p3)
     The Symbolic Ring
 }}}

 > What is changing here is the parent of the result, not the actual
 result. In particular, the new version is converting some of the Symoblic
 Ring cases back to a polynomial. So a new example would need to test the
 parent of the result, which seemed a little odd.

 If the parent changes, then the result does change! This kind of things is
 exactly the purpose of the `TESTS` section. Note that there are examples
 of that in the Sage library (like checking that the output is a Sage
 Integer and not an int, or similar things).

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/18409#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to