#18436: Dimension formulae do not accept Dirichlet characters with certain base
rings
-------------------------------------+-------------------------------------
       Reporter:  pbruin             |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  modular forms      |   Resolution:
       Keywords:  Dirichlet          |    Merged in:
  character dimension formula        |    Reviewers:
        Authors:  Peter Bruin        |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  a38e707bc54952c8ac5f84353c2d3566b206fb69
  u/pbruin/18436-dimension_formulae  |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by pbruin):

 Replying to [comment:5 chapoton]:
 > OK. Looks good to me, but I would prefer to check the characteristic of
 K before
 > changing the base of eps.
 The line `eps = DirichletGroup(N, K)(eps)` doesn't change the base ring of
 `eps`, just the level.  Switching the order with the check for the
 characteristic of `K` makes no difference except that this one line more
 than necessary is executed in case of invalid input.  I actually had
 similar thoughts as you while I was writing the patch, and decided on what
 I think is a fairly logical ordering of the code.  I don't think we would
 gain a lot by modifying the order.

--
Ticket URL: <http://trac.sagemath.org/ticket/18436#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to