#17492: Speedup k-closed check
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.8
Component: matroid theory | Resolution:
Keywords: k-closed | Merged in:
Authors: Travis Scrimshaw | Reviewers: Rudi Pendavingh
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/tscrim/k_closed_speedup-17492 | 6fc7e6e986326b80ef4e32de1ee127ada1dd84b0
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_review => positive_review
* reviewer: => Rudi Pendavingh
Comment:
Replying to [comment:5 Rudi]:
> I checked out this patch and it all works as advertised. Positive
review, except for one thing:
Thank you for the review.
> A merge with 'master' was necessary before sage -b would successfully
build this on my sage 6.7. The logical thing would perhaps be to push the
merged branch I created, but I hesitate to do this since my recent
experience with git tell me that I might not fully understand how things
work when it comes to this. Perhaps there is another, better way, and also
I do not want to risk messing up your work.
>
> So please update the branch to something that compiles out of the box,
or argue that this is unnecessary. Then feel free to set this to 'positive
review'.
The branch is merged with the latest `develop` at merge time, so if this
works after merging (cleanly, i.e., without having to handle any merge
conflicts) with `master` (or now `develop` at 6.8.beta0), there should be
no problems.
For the record, my usual workflow is to always merge the branch into my
current `develop` branch as my current spkgs might be incompatible with
older versions of Sage. Plus it saves on compilation time. Also if you
push it to a different branch and set that, there is no way to corrupt my
work on my branch.
Thank you again.
--
Ticket URL: <http://trac.sagemath.org/ticket/17492#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
