#18448: Add test if a matroid is binary
-------------------------------------+-------------------------------------
Reporter: Rudi | Owner: Rudi
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.8
Component: matroid theory | Resolution:
Keywords: | Merged in:
Authors: Rudi Pendavingh | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/Rudi/add_test_if_a_matroid_is_binary|
171a780335181612a97b40bd6cefb707f9b2af37
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
From looking through it, there are a couple of things to fix:
- Instead of `type(self) == BinaryMatroid`, you should do
`isinstance(self, BinaryMatriod)` (or even better, for `is_binary`, I
would just overwrite this method in that class which returns `True`).
- You need to fix the documentation of your methods. For example, the
`INPUT:` block should only have one colon. You can look at the other
nearby methods or ask me if you have any questions. I'd also add some
latex formating to things using single backticks, e.g., {{{`|X\B| \leq
1`}}}.
--
Ticket URL: <http://trac.sagemath.org/ticket/18448#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
