#18558: Test all installed packages by default
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
doctest framework | Work issues:
Keywords: | Commit:
Authors: | 1ffc3c1a7a909b1d75653f9951da869371cc1039
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/18558 |
Dependencies: |
#18456, #18124 |
-------------------------+-------------------------------------------------
Comment (by ncohen):
> I don't expect them to pass tests. In fact, that was the whole point of
my argument. They are known to fail tests, but so be it. Just don't force
everybody to see those failures.
Everybody wil not. Only the *developers* who *run the doctests* and *have
the package installed* will see them. And that's precisely the guys who
should fix it.
> They should not be removed, unless the doctest itself (not the code that
it tests or the result) is somehow bad. That's what `# known bug` is for:
to be able to keep the doctest but not see the failure in every `make
ptest` run.
Fine. You are allowed to flag a doctest as "known bug" whenever you want.
This branch does nto change that.
> My idea with experimental packages is that marking a package as
"experimental" acts like adding `# known bug` to every optional doctest of
that package.
What is the point of doctests then? `O_o`
> I am trying to solve this in a constructive way. I proposed several
alternative solutions (such as marking tests as # known bug or testing
only optional packages) which would make this ticket acceptable for me and
which are "*doable* and *reasonable*".
Marking all tests as known bug is dangerous: we want to find the bugs, and
we want to fix them. Testing optional packages only is what this branch
did at first, until I was asked to make it otherwise. Agree with
yourselves, and I will update the ticket, but I don't want to keep
changing branches forever.
Addtionally, I cannot by myself go over all optional/experimental packages
and make changes to all of them. You can't ask me that, this is not
*reasonable*. That's why I mentionned merged this branch in a beta0, so
that everybody can participate to the effort until the next release. This,
on the other hand, is a good outcome, and will ensure that the job is done
properly.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18558#comment:39>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
