#18566: Warning when installing new-style experimental packages
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.8
      Component:  packages:          |   Resolution:
  experimental                       |    Merged in:
       Keywords:                     |    Reviewers:  Jeroen Demeyer
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/18566       |  b4d152bc305eed215af74a0c51c39043ce781a8d
   Dependencies:  #18563             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):

 * status:  needs_review => needs_work
 * reviewer:   => Jeroen Demeyer


Comment:

 I would change
 {{{
 if [ `cat "$PKG_SCRIPTS/type"` == "experimental" ]
 }}}
 to
 {{{
 if [ x`cat "$PKG_SCRIPTS/type"` = xexperimental ]
 }}}
 which has less chances of trouble (in case of a missing/empty `type` file
 for example).

--
Ticket URL: <http://trac.sagemath.org/ticket/18566#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to