#11187: Implementation of finite reflection groups
-------------------------------------+-------------------------------------
       Reporter:  stumpc5            |        Owner:  tbd
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:  reflection group,  |    Merged in:
  days49                             |    Reviewers:
        Authors:  Christian Stump    |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  c0a036b2e2f01b1be6a7d004373fafe0c399e14d
  u/SimonKing/11187-new              |     Stopgaps:
   Dependencies:  #8327 #14137       |
-------------------------------------+-------------------------------------
Changes (by SimonKing):

 * commit:  425ca38c084a51fa56c301153165269031fb5e0d =>
     c0a036b2e2f01b1be6a7d004373fafe0c399e14d


Comment:

 After discussion with Christian, the iterator of a complex reflection
 group is a lot faster. What we did was to keep `._reduced_word` as a list,
 and only transform it into an actual word when needed (i.e., in the
 `.reduced_word()` method).

 Before:
 {{{
 sage: G = ComplexReflectionGroup([2,1,4])
 sage: %timeit L = list(G); G._elements=None
 The slowest run took 6.02 times longer than the fastest. This could mean
 that an intermediate result is being cached
 1 loops, best of 3: 66.4 ms per loop
 }}}
 After:
 {{{
 sage: G = ComplexReflectionGroup([2,1,4])
 sage: %timeit L = list(G); G._elements=None
 The slowest run took 66.44 times longer than the fastest. This could mean
 that an intermediate result is being cached
 1 loops, best of 3: 5.56 ms per loop
 }}}
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=c0a036b2e2f01b1be6a7d004373fafe0c399e14d
 c0a036b]||{{{Avoid creation of _reduced_word during iteration}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/11187#comment:49>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to