#18086: Twists of newforms
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.6
Component: modular forms | Resolution:
Keywords: twist newform | Merged in:
Dirichlet character | Reviewers: Chris Wuthrich, David
Authors: Peter Bruin | Loeffler
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/davidloeffler/18086-rebased | 751bf48f8c2f65fd4a7478e0b22fbe76c6edf3bb
Dependencies: #6837, #18436, | Stopgaps:
#18479 |
-------------------------------------+-------------------------------------
Changes (by pbruin):
* status: needs_review => positive_review
Comment:
I saw the git-related messages come by but didn't have time to look into
it. I think the way you solved it is good, although the branch at #18061
is now less tidy than it would have been if you had used merging instead
of rebasing. (The situation might have been clearer if I had merged
#18479; I don't always find it easy to decide if and when dependencies
should be merged into a branch.)
Thanks to both of you for the review!
--
Ticket URL: <http://trac.sagemath.org/ticket/18086#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
