#18086: Twists of newforms
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: modular forms | Resolution:
Keywords: twist newform | Merged in:
Dirichlet character | Reviewers: Chris Wuthrich, David
Authors: Peter Bruin | Loeffler
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/davidloeffler/18086-twists- | d57edf416adaace77e013e71223b1b5bae7d686a
merged | Stopgaps:
Dependencies: #6837, #18436, |
#18479 |
-------------------------------------+-------------------------------------
Changes (by davidloeffler):
* reviewer: Chris Wuthrich => Chris Wuthrich, David Loeffler
Comment:
Right, I created a new branch which has only the relevant commits on top
of current "master", using the rather useful "git cherry-pick" command,
and now I'm testing that.
But I don't think the example from comment 14 is fixed yet. With #18479 in
place, calling {{{eps.minimize_base_ring()}}} works fine, but still
{{{f.twist(eps)}}} returns exactly the same error. I've traced this to
sloppy coding in some dimension counting functions. I also spotted another
error in {{{minimize_base_ring()}}}, unrelated to #18479, when the
coefficient field is a relative number field.
With these two changes the code looks sound. Peter: if you're happy with
these changes, please set the ticket to positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/18086#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
