#18589: isogeny efficiency improvement
-------------------------+-------------------------------------------------
Reporter: | Owner:
cremona | Status: needs_work
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Jeroen Demeyer
elliptic curves | Work issues:
Keywords: | Commit:
isogeny | 3d687e5225f67808eb6c5af5fbf4cb93f2000c62
Authors: John | Stopgaps:
Cremona |
Report Upstream: N/A |
Branch: |
u/cremona/18589 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by cremona):
Replying to [comment:44 jdemeyer]:
> Replying to [comment:42 git]:
> > Branch pushed to git repo; I updated commit sha1. New commits:
> >
||[http://git.sagemath.org/sage.git/commit/?id=2f83c20a3753b9141c635ab26ed88015a9fed499
2f83c20]||{{{#18589: 2 simplifications following review}}}||
>
> The check {{{not factors_by_degree}}} only checks that the dict has no
keys, but you really need to check that all values are empty lists:
> {{{
> all(factors == [] for factors in factors_by_degree.values())
> }}}
You are right, I had forgotten that in creating the dict it might have had
some empty lists. I should have known better than to do more
simplifaction than you recommended!
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=3d687e5225f67808eb6c5af5fbf4cb93f2000c62
3d687e5]||{{{#18589 further one-liner}}}||
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=3d687e5225f67808eb6c5af5fbf4cb93f2000c62
3d687e5]||{{{#18589 further one-liner}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18589#comment:47>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
