#18581: _package_lists_from_sage_output() should output installed and available
versions
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.8
Component: misc | Resolution:
Keywords: | Merged in:
Authors: John Palmieri | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jhpalmieri/versions | 61a40761c68b5b054ff86a0d8d4102556b9dcf58
Dependencies: #18456 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Nathann, in #18456 you decided to change
{{{
def split_pkgname(name):
try:
basename, version = name.split('-', 1)
except ValueError:
# Some packages such as currently "csage" aren't versioned, or
# have non-standard versioning, e.g.
"database_stein_watkins_mini.p0".
basename = name
version = ""
return basename, version
}}}
to
{{{
def pkgname_split(name):
pname = name.split(' ')[0]
pname = re.sub("(\.|-)p[0-9]+$","",pname) # strip .p0
pname = re.sub("(\.|-)[0-9].*","",pname) # strip version number
return (pname,name[len(pname)+1:])
}}}
without justification or giving a reason why the latter is correct (where
did those regexes come from?)
Unless you can give me a good reason why you changed that, I'm proposing
to undo that change.
--
Ticket URL: <http://trac.sagemath.org/ticket/18581#comment:44>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
