#18437: Remove PolyBoRi's dependency on scons
-------------------------------------+-------------------------------------
Reporter: ohanar | Owner:
Type: task | Status: needs_info
Priority: major | Milestone: sage-6.8
Component: packages: | Resolution:
standard | Merged in:
Keywords: | Reviewers:
Authors: R. Andrew Ohana | Work issues:
Report Upstream: N/A | Commit:
Branch: | c30cf70daf27791feb128534cb1fad4d5b0dd652
u/ohanar/polybori_autotools | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ohanar):
Replying to [comment:31 jdemeyer]:
> Is this commit
[https://github.com/ohanar/PolyBoRi/commit/a91362c5be91b2fb23f8acf609852381b78b15a4]
part of the tarball on this commit?
Yes.
> I would prefer to see it as a patch in `build/pkgs/polybori/patches`
(and on a different ticket).
I would not. As I see it there are three routes we could go with polybori:
1. We adopt the route that we took with Pynac (as a fork of Ginac). Our
fork might in the future become tightly coupled with Sage, but we maintain
it as a separate package outside of Sage.
2. We make a minimal fork, only include the minimal changes necessary to
build polybori without scons. If more substantive changes are needed, we
include those in the Sage library.
3. A hybrid approach: maintain a minimal fork, and a maintain a set of
patches for more substantive changes.
I really dislike option 3 (which seems to be the one you are voting for).
It seems like it just adds the unnecessary work of maintain patches, with
no real benefit. Upon reflection, I would vote for 1, since it allows us
make changes to the c++ source if we need to in the future.
If we go with option 1, I would rename this ticket to "Switch from
polybori to XXXX", where XXXX is our fork of polybori (still needs a name,
I haven't been 100% happy with anything I've come up with). In that case,
I view it as perfectly acceptable for there to be additional changes to
the fork, such as the Python 3 changes I made.
----
Also, @fbissey. The author of cudd got back to me finally, he said he was
already planning on making a new release sometime this summer which uses
autotools. Until then, I think I'll continue bundling it with polybori.
--
Ticket URL: <http://trac.sagemath.org/ticket/18437#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
