#18443: Multiplier spectra for projective morphisms
-------------------------------------+-------------------------------------
       Reporter:  gjorgenson         |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  minor              |    Milestone:  sage-6.8
      Component:  algebraic          |   Resolution:
  geometry                           |    Merged in:
       Keywords:                     |    Reviewers:  Ben Hutz
        Authors:  Grayson Jorgenson  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  3aca932972ebf48911a05bcfef34d248b7a33e88
  u/gjorgenson/ticket/18443          |     Stopgaps:
   Dependencies:  #18409             |
-------------------------------------+-------------------------------------
Changes (by bhutz):

 * status:  needs_review => needs_work


Comment:

 Just a couple very minor things here. You should actually convert n, not
 just check the conversion. ie. use ``n=int(n)``

 Also, I'd rather not have you accessing the ._polys list directly. Instead
 you can use G[0], G[1], etc.

 Finally, I'd like to see an example with multiplicities.

 I see you directly implemented the QQbar change ring for the dynatomic
 polynomial. I still think the .change_ring() should be fixed as well, but
 that can be done in a different ticket.

--
Ticket URL: <http://trac.sagemath.org/ticket/18443#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to