#18003: Implement Fully Packed Loop class
-------------------------------------+-------------------------------------
       Reporter:  kdilks             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.6
      Component:  combinatorics      |   Resolution:
       Keywords:  fpl, ncp, days64,  |    Merged in:
  days65, asm, lp, fully packed      |    Reviewers:  Jessica Striker,
  loop                               |  Travis Scrimshaw
        Authors:  James Campbell,    |  Work issues:  create a parent class
  Vince Knight, Jessica Striker,     |       Commit:
  Kevin Dilks, Emily Gunawan         |  310eb70ad9b93932f34316fd52628af3568d8362
Report Upstream:  N/A                |     Stopgaps:
         Branch:                     |
  public/ticket/18003                |
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by tscrim):

 Some notes about your `_element_constructor_`, you don't need to check
 `fpl.parent() is self`, as the coercion model has already checked that and
 would have returned that. Which is why your test actually works. If you
 try to pass in the ASM, your `_element_constructor_` will return `None`. I
 think what you should do is copy the implementation from
 `__classcall_private__` into `_element_constructor_` and then have
 `__classcall_private__` return `FPLs(generator)`. You might also want to
 consider passing other types of data to a corresponding SVM in the
 `_element_constructor_`.

 You can test for a SVM to be the square ice configuration by
 `isinstance(SVM, SquareIceModel.Element)`.

--
Ticket URL: <http://trac.sagemath.org/ticket/18003#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to