#18127: Optional package lrs-4.2b.p1.spkg needs updating
-------------------------------------+-------------------------------------
       Reporter:  yzh                |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.6
      Component:  packages:          |   Resolution:
  optional                           |    Merged in:
       Keywords:  lrs, redund        |    Reviewers:
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  29405f65b2b739370ce050c6895aebeb29492fc4
  u/mkoeppe/optional_package_lrs_4_2b_p1_spkg_needs_updating|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * status:  new => needs_review


Comment:

 Hellooooooo,

 - You cannot 'just rename' the package: there are many doctests flagged
 with
   "optional - lrs" (which are only tested if 'lrs' is installed), and if
 you
   rename the package but not those doctests then they will not be tested
 as they
   should. You will find them in three files:
   {{{
   game_theory/normal_form_game.py
   game_theory/parser.py
   geometry/polyhedron/base.py
   }}}

 - A ticket that updates a package must contain a direct url toward the
 archive
   that is to be added (for the release manager who will have to merge the
   ticket)

 - Do you know what are the differences between lrs and lrslib (if any)? It
 seems
   that the author's website still lists 'lrs' as something different from
   'lrslib'.

 - You can drop the "Changelog" section of SPKG.txt. That's because we now
 have
   the history in the main git tree.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/18127#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to