#18720: Change diagram algebra basis set partitions from list to generator
-------------------------------------+-------------------------------------
Reporter: ghseeli | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: sage-6.8
Component: algebra | Resolution:
Keywords: days65, partition | Merged in:
algebra, diagram algebra | Reviewers:
Authors: ghseeli | Work issues:
Report Upstream: N/A | Commit:
Branch: | e4be96d59952d27edbce56c914cbefd65e3b9ad7
u/ghseeli/change_diagram_algebra_basis_set_partitions_from_list_to_generator|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
Thank you for your work on cleaning up the diagram algebras. I know this
isn't yet ready for review, but some comments:
You should try to avoid changing the behavior of any public functions.
Instead I would create an iterator method (perhaps make it hidden?) and
then the original function just calls `list(iterator_method)`.
You shouldn't use `CombinatorialClass` and `CombinatorialObject` but
instead `Parent, UniqueRepresentation` and `ClonableArray` respectively as
these are being deprecated. Also you should set the `Element =
PartitionDiagram` in `PartitionDiagrams` (the order of which will need to
be swapped in the file). If you put `PartitionDiagrams` in the category of
`FiniteEnumeratedSets`, then you don't need to define a `list` and
`cardinality` methods (maybe even `__contains__`, I forget offhand). The
`PartitionDiagram` class will also need to have parent be passed as the
first argument.
Let me know if you have any questions.
--
Ticket URL: <http://trac.sagemath.org/ticket/18720#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
