#18720: Change diagram algebra basis set partitions from list to generator
-------------------------------------+-------------------------------------
Reporter: ghseeli | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: sage-6.8
Component: algebra | Resolution:
Keywords: days65, partition | Merged in:
algebra, diagram algebra | Reviewers:
Authors: ghseeli | Work issues:
Report Upstream: N/A | Commit:
Branch: | c179733742da1d36d3ca7bd8e856be902cb5f30e
u/ghseeli/change_diagram_algebra_basis_set_partitions_from_list_to_generator|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
Replying to [comment:7 ghseeli]:
> Okay, I will do those changes. I do have plans for the other classes,
but I have not finished polishing up the methods. At the moment, really
the only one I have special methods for is `BrauerDiagrams`, but I can
imagine special methods applying to other types of diagrams. For instance,
it is usually possible to determine if a diagram is a certain type of
diagram without generating the entire list of those diagrams of order n.
However, I assume the contains method of `FiniteEnumeratedSets` currently
needs to create the entire list?
Yes, that is correct. So if you have a better solution using
`__contains__`, this completely justifies having separate classes.
> However, it may be possible to reduce the number of classes; I will
think about the best way to logically do it while preserving the
functionality I want to add.
Don't worry too much about it. It's better that the code is readable and
grouped into functionality (i.e., good OOP). It was just if they were
going to be classes that passed data up to a base class, then I didn't see
a reason to keeping them.
--
Ticket URL: <http://trac.sagemath.org/ticket/18720#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
