#17618: Update matplotlib so that plot_directive is less broken
-------------------------------------+-------------------------------------
Reporter: tmonteil | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: packages: | Resolution:
standard | Merged in:
Keywords: | Reviewers: Steven Trogdon
Authors: Thierry Monteil, | Work issues:
François Bissey | Commit:
Report Upstream: N/A | 32afbe15955286dfaf2f3f270ca2e231aa8f0af7
Branch: | Stopgaps:
u/tmonteil/MPL1.4.3 |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tmonteil):
* status: needs_info => needs_review
Comment:
Replying to [comment:65 ncohen]:
> {{{
> +[ -n "${SAGE_ROOT}" ] || SAGE_ROOT="$(pwd)/../../../"
> }}}
>
> Isn't it cleaner to just stop (as `spkg-install` does when `SAGE_LOCAL`
is not defined)?
>
The checks done to some `spkg-install` scripts are here to ensure that the
script is run from the Sage shell, because they use its features (e.g.
some environment variables like `${MAKE}`). Here, in contrary to such
`spkg-install` scripts, there is no need to check that since the script do
not use such feature, except `${SAGE_ROOT}` that can be recovered from the
current location.
Replying to [comment:66 strogdon]:
> Perhaps something does need to be done. I don't know what the protocol
for these `spkg-src` scripts is. The present script does work from a sage
shell. However, if not in a sage shell, it fails with something like
> {{{
> tar (child): /64bitdev/storage/sage-
git_develop/sage/../../..//upstream/matplotlib-1.4.3.tar.bz2: Cannot open:
No such file or directory
> tar (child): Error is not recoverable: exiting now
> }}}
> unless executed from the `build/pkgs/matplotlib` folder. So setting this
back to `needs_info` until it can be resolved.
The whole "protocol" can be found
[http://www.sagemath.org/documentation/html/en/developer/packaging.html
#modified-tarballs here], which is pretty vague regarding the importance
to be run from the Sage shell.
How i see it, this script is intented to be run by maintainers, ease of
use is prefered over security, which is pretty different from `spkg-
install` that is run by users and should be pretty strict regarding
misuses. The aim is not to have a script that could be run from anywhere,
obfuscated with tons of tests, but should deserve the following purposes:
- document and make transparent the differences between the upstream
tarball and the one we distribute (hence the comments above each
paragraph),
- be a handy tool to save some time for next updates (hence the
autodiscovery of latest version and download url, and the possibility to
be run from the developer's shell),
- i would add perfect reproductibility of distributed tarballs, but it
seems that nobody cares.
--
Ticket URL: <http://trac.sagemath.org/ticket/17618#comment:68>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
