#17618: Update matplotlib so that plot_directive is less broken
-------------------------------------+-------------------------------------
Reporter: tmonteil | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: packages: | Resolution:
standard | Merged in:
Keywords: | Reviewers: Steven Trogdon
Authors: Thierry Monteil, | Work issues:
François Bissey | Commit:
Report Upstream: N/A | 32afbe15955286dfaf2f3f270ca2e231aa8f0af7
Branch: | Stopgaps:
u/tmonteil/MPL1.4.3 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by strogdon):
I don't think checking for `SAGE_ROOT` is necessarily a bad idea. And the
protocol doesn't seem to require the script to be run from the Sage shell.
What if something like the following, in addition to the latest commit,
were added
{{{
--- a/build/pkgs/matplotlib/spkg-src
+++ b/build/pkgs/matplotlib/spkg-src
@@ -2,6 +2,10 @@
set -e
+printf "This script should be run as ./spkg-src from the repository to
which it
+belongs, or from the Sage shell.\n"
+read -rsp $'Press any key to continue or \'CTRL+C\' to exit :\n' -n1 key
+
[ -n "${SAGE_ROOT}" ] || SAGE_ROOT="$(pwd)/../../../"
}}}
Off hand I don't know how to check if one is `in` the correct repository.
And perhaps giving the warning is enough.
--
Ticket URL: <http://trac.sagemath.org/ticket/17618#comment:75>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
