#18608: Arc method in BalancedIncompleteBlockDesign class
-------------------------------------+-------------------------------------
Reporter: q.honore | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.8
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers: Vincent Delecroix
Authors: Quentin Honoré | Work issues:
Report Upstream: N/A | Commit:
Branch: public/18608 | a76436a4bb79e315938816cce5798f0c8099cc03
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
* reviewer: => Vincent Delecroix
Comment:
Hello,
Sometimes you use one back quote as {{{`(s,n)`}}} and sometimes two as
{{{``s``}}}. As you can see, the rendering is quite different in the
documentation. The single backquote is used for LaTeX code while the
double is used to mention the parameters of the algorithm. Try to not mix
them in the same line.
It is dangerous to return `self._points` directly as it might be modified
by the users. Return rather a copy of it using `return self._points[:]`.
The rest looks good.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18608#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
