#18756: Use coerce actions in the category framework
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: coercion | Resolution:
Keywords: cython, coercion, | Merged in:
actions, categories | Reviewers: Travis Scrimshaw
Authors: Simon King | Work issues:
Report Upstream: N/A | Commit:
Branch: | a5bdbf6f85ea0d732a13ebc7d8e91dbd28c92ef0
u/SimonKing/combinatorial_free_module_cython_coercion| Stopgaps:
Dependencies: #18795 |
-------------------------------------+-------------------------------------
Changes (by SimonKing):
* status: needs_work => needs_review
Comment:
I believe this is ready for review now. The dependency #18795 is ready,
too, but isn't merged here, which I believe is the correct thing to do, or
should I merge it?
Concerning the question on whether or not we should go up the mro and the
categories: I think it makes sense to do it. Different algebraic structure
/ categories have different stories to tell about different actions.
Hence, either it is requested to explicitly call
"`super(...)._get_action_`" resp. hardcode all specific situations when
implementing `_get_action_`, or we do the super call automatically.
And I believe automatically is the more stable solution.
There remains the question if it slows down one or another computation. Do
you have ideas for suitable benchmarks? They would involve lots of
''different'' parent engaged in actions, since `Parent.get_action` is
cached and thus won't slow down when repeatedly requeting an action for
always the same parents.
--
Ticket URL: <http://trac.sagemath.org/ticket/18756#comment:43>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
