#18826: A sage-sanity-check-package using the 'spkg-src' scripts
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: major | Merged in:
Component: build | Reviewers:
Keywords: | Work issues:
Authors: | Commit:
Nathann Cohen | ef4e8b06491e61345809e10b349c03f6d54136a9
Report Upstream: N/A | Stopgaps:
Branch: |
public/18826 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Yooooooooooo !
> I agree with Nathann that `spkg-src` scripts are inconsistent and should
be improved.
Yep `T_T`
> I'd like to modify the assumptions a bit though:
> 1. The `spkg-src` script should only be run within a Sage shell.
How can you check that? Or do you mean that my script should only run them
from the inside of a sage shell? If so, would replacing 'spkg-src' with
'sage -sh spkg-src' in the script be sufficient?
> 1. The `spkg-src` script should be runnable from any directory (do not
assume the current directory is `build/pkgs/PKGNAME`)
I do not know how to check that either. In a preliminary version of my
script I wanted to work in a different directory, but I figured out that
most spkg-src files would break at this step.
> 1. The tarball should be created in the `$SAGE_DISTFILES` directory.
That would break the way the script currently works. It *compares* the
file created by spkg-src with the one in `upstream/`. How could we deal
with that?
> 1. The script shall not change any file (not even temporary) outside
`$SAGE_DISTFILES`.
Well, it will need some temporary directory anyway.
> So, `./sage --sh build/pkgs/PKGNAME/spkg-src` should "just work".
You are making requests which would make this script much more
restrictive. If you already know how to implement some of them, feel free
to add a commit on this public branch (with explicit error messages).
When we will have settled on that, we will also have to explain all this
(and go over all assumptions) in the developer manual.
Thanks,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18826#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
