#18826: A sage-sanity-check-package using the 'spkg-src' scripts
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  ncohen                 |       Status:  needs_review
           Type:         |    Milestone:  sage-6.8
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:  build  |    Reviewers:
       Keywords:         |  Work issues:
        Authors:         |       Commit:
  Nathann Cohen          |  ef4e8b06491e61345809e10b349c03f6d54136a9
Report Upstream:  N/A    |     Stopgaps:
         Branch:         |
  public/18826           |
   Dependencies:         |
-------------------------+-------------------------------------------------

Comment (by jdemeyer):

 Replying to [comment:10 ncohen]:
 > How can you check that?
 I didn't say that you script should ''check'' all conditions. We need to
 define how the `spkg-src` script should be run, so we need to state the
 conditions precisely.

 > Or do you mean that my script should only run them from the inside of a
 sage shell?
 Yes.

 > > 1. The `spkg-src` script should be runnable from any directory (do not
 assume the current directory is `build/pkgs/PKGNAME`)
 >
 > I do not know how to check that either.
 {{{
 cd /
 "$SAGE_ROOT/build/pkgs/$PKGNAME/spkg-src
 }}}

 > > 1. The tarball should be created in the `$SAGE_DISTFILES` directory.
 >
 > That would break the way the script currently works. It *compares* the
 file created by spkg-src with the one in `upstream/`. How could we deal
 with that?
 {{{
 SAGE_REAL_DISTFILES="$SAGE_DISTFILES"
 export SAGE_DISTFILES=/some/temporary/directory
 cd /
 "$SAGE_ROOT/build/pkgs/$PKGNAME/spkg-src
 compare "$SAGE_REAL_DISTFILES/$TARBALL" "$SAGE_DISTFILES/$TARBALL"
 }}}

 > Well, it will need some temporary directory anyway.
 I think it could use `$SAGE_DISTFILES` as temporary directory.

--
Ticket URL: <http://trac.sagemath.org/ticket/18826#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to