#17392: Make list of built-in normal form games
-------------------------------------+-------------------------------------
Reporter: kcrisman | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.8
Component: game theory | Resolution:
Keywords: days64 | Merged in:
Authors: Vincent Knight, | Reviewers: Karl-Dieter Crisman,
James Campbell | Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vinceknight/catalog_of_games | 2c111e2047c17e4c4641dc74a23c83a978389623
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: positive_review => needs_work
Comment:
Sorry for not responding sooner, I've been busy moving out of my house and
having to choose my time (and the past 17 hours, been traveling from SF to
Korea). Here are my thoughts, not that they really count for much.
I try and keep to the 80 char/line limit, and what Vince did initially is
the "best" practice according to PEP8. However, I side with Karl-Dieter on
this in that it just looks ugly and it's worth it to consolidate the data
and go past 80 char/line limit when it is easier to read.
However I do have an issue with this sentence:
{{{#!diff
+When we test whether the game is actually the one in question, sometimes
we will
+build a dictionary to test it, since this can be platform-dependent, like
so::
}}}
What is "this"? In particular, when I first read this, to me it seemed
like the actual output could be different on different machines, whereas
it is only the print representation of the dictionary used to model the
game. Your change doesn't have to be as verbose as that (IMO), just change
"this" to "the printed representation" or something like that.
Once you make that change, you can set this back to positive review on my
behalf.
--
Ticket URL: <http://trac.sagemath.org/ticket/17392#comment:77>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
