#18837: module_list.py: remove foo_depends variables
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.8
Component: cython | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/18837 | 37a7a107a1e763164f857e19b81f8726ee57a3df
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* cc: jpflori (added)
* commit: => 37a7a107a1e763164f857e19b81f8726ee57a3df
* status: new => needs_review
Old description:
> These days, Cython knows that included files are a dependency. So in most
> cases, the `depends = [...]` lines in `module_list.py` are not needed.
>
> This ticket removes `flint_depends`, `singular_depends` and
> `givaro_depends` with one exception: the dependency of
> `sage.libs.linbox.linbox` on Givaro is not automatically detected (I
> don't know whether it's a real dependency, but I'm keeping the explicit
> dependency to be safe).
>
> To check that Cython really knows the dependencies, you can check the
> metadata on top of each generated `.c`/`.cpp` file. You will see that
> (with the one exception mentioned before), Cython knows the dependencies.
>
> Note that in some cases, `flint/flint.h` was a dependency before but not
> after this ticket. In all those cases, other FLINT files like
> `flint/ulong_extras.h` are still a dependency, so this is not a problem.
New description:
These days, Cython knows that included files are a dependency. So in most
cases, the
{{{
depends = [...]
}}}
lines in `module_list.py` are not needed.
This ticket removes `flint_depends`, `singular_depends` and
`givaro_depends` with one exception: the dependency of
`sage.libs.linbox.linbox` on Givaro is not automatically detected (I don't
know whether it's a real dependency, but I'm keeping the explicit
dependency to be safe).
To check that Cython really knows the dependencies, you can check the
metadata on top of each generated `.c`/`.cpp` file. You will see that
(with the one exception mentioned before), Cython knows the dependencies.
Note that in some cases, `flint/flint.h` was a dependency before but not
after this ticket. In all those cases, other FLINT files like
`flint/ulong_extras.h` are still a dependency, so this is not a problem.
--
Comment:
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=37a7a107a1e763164f857e19b81f8726ee57a3df
37a7a10]||{{{Remove foo_depends variables}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18837#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
