#18748: Python library to bootstrap Sage
-------------------------------------+-------------------------------------
Reporter: vbraun | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.8
Component: build | Resolution:
Keywords: | Merged in:
Authors: Volker Braun | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vbraun/python_library_to_bootstrap_sage|
e45a0b667f908f147cabbec63fe88134061ac69a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jhpalmieri):
Minor questions:
- In `package.py`, are the lines
{{{
def __eq__(self, other):
return self.tarball == other.tarball
}}}
there just for testing via `tox`, or do they serve another purpose?
- There are some blank spaces on several otherwise empty lines in
`tarball.py`. Do we care?
Overall, the code is just a relocation of old code, so that's okay. I'm
not sure about the whole idea of moving it. Seems okay to me, but it
doesn't strike me as very high on the priority list.
Less minor questions and comments:
- What does `sage-package` do? The file itself should contain some
information; you shouldn't have to run it to get its usage message. Maybe
the same could be said for `sage-download-file`, but at least the name is
somewhat self-explanatory. I think you should add a line or two there,
also. Probably in `README`, too, for example after the sentence
{{{
This is a utility libary for dealing with third-party tarballs and
building Sage.
}}}
(Something like "The main entry points are sage-download-file and sage-
package, which are used as follows: ...". Note also that "libary" is
currently misspelled.)
- In addition, I think that each python file in `sage_bootstrap` could
have a bit more documentation, illustrating how to use it. I don't really
want to have to read the source code to figure out this sort of thing. For
`download.py`, for example, mention `Download(...).run()`.
- Add the link `https://tox.readthedocs.org` to `README`. Maybe we should
all know about tox already, but that doesn't seem to be the case.
--
Ticket URL: <http://trac.sagemath.org/ticket/18748#comment:45>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
