#18748: Python library to bootstrap Sage
-------------------------------------+-------------------------------------
Reporter: vbraun | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.8
Component: build | Resolution:
Keywords: | Merged in:
Authors: Volker Braun | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vbraun/python_library_to_bootstrap_sage|
e45a0b667f908f147cabbec63fe88134061ac69a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vbraun):
Replying to [comment:45 jhpalmieri]:
> - In `package.py`, are the lines
> {{{
> def __eq__(self, other):
> return self.tarball == other.tarball
> }}}
> there just for testing via `tox`, or do they serve another purpose?
They are used for testing in unittest.TestCase.assertEqual, doesn't really
have anything to do with tox (which is just the test runner) besides that.
> - There are some blank spaces on several otherwise empty lines in
`tarball.py`. Do we care?
I don't.
> Overall, the code is just a relocation of old code, so that's okay. I'm
not sure about the whole idea of moving it. Seems okay to me, but it
doesn't strike me as very high on the priority list.
The old script was already too long to fit comfortably into one file, with
added testing its can't fit into one file. So it has to grow into a
package.
> Less minor questions and comments:
> - What does `sage-package` do?
It mostly makes the release manager's job easier because you don't have to
log into the server and associated tarball names to package names by hand,
which wastes my preciously little available time.
I'm happy to add a line of documentation here or there but unlike the math
part this is **not** a library for Python novices. IMHO its not too much
to ask to google for "tox", thats bound to produce way more relevant and
informative information than I can possibly be.
--
Ticket URL: <http://trac.sagemath.org/ticket/18748#comment:46>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
