#18860: Faster Poyhedron.graph()
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
geometry | Work issues:
Keywords: | Commit:
Authors: | 74d8412010748142918edf6178636bffdb14e60a
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18860 |
Dependencies: |
#18779 |
-------------------------+-------------------------------------------------
Comment (by dimpase):
Replying to [comment:23 ncohen]:
> > Aren't we changing the behaviour of some functions for the non-compact
case?
>
> also note that not a single doctest changed. But to be honest, I still
believe that the `._vertex_adjacency_matrix` should be either fixed or
renamed. It is not what it claims to be.
presently we have
{{{
adjacency_matrix = vertex_adjacency_matrix
}}}
in `geometry/polhedron/base.py`. I'd think we should rename
`._vertex_adjacency_matrix` to something like `._Vrep_adjacency_matrix`,
and, dually `._facet_adjacency_matrix` to `._Hrep_adjacency_matrix`.
And then set `adjacency_matrix = _Vrep_adjacency_matrix`, and provide a
meaningful implementation of `vertex_adjacency_matrix`, as you propose
here.
--
Ticket URL: <http://trac.sagemath.org/ticket/18860#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
