#18860: Faster Poyhedron.graph()
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_work
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Dima Pasechnik
geometry | Work issues:
Keywords: | Commit:
Authors: | 74d8412010748142918edf6178636bffdb14e60a
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18860 |
Dependencies: |
#18779 |
-------------------------+-------------------------------------------------
Changes (by vbraun):
* status: positive_review => needs_work
Comment:
{{{
sage -t --long src/sage/graphs/generators/random.py
**********************************************************************
File "src/sage/graphs/generators/random.py", line 806, in
sage.graphs.generators.random.RandomTriangulation
Failed example:
for i in range(10):
g = graphs.RandomTriangulation(30,embed=True)
assert g.is_planar() and g.size() == 3*g.order()-6
Exception raised:
Traceback (most recent call last):
File
"/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File
"/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest
sage.graphs.generators.random.RandomTriangulation[3]>", line 3, in
<module>
assert g.is_planar() and g.size() ==
Integer(3)*g.order()-Integer(6)
File
"/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4035, in is_planar
planar =
is_planar(G,kuratowski=kuratowski,set_pos=set_pos,set_embedding=set_embedding)
File "sage/graphs/planarity.pyx", line 99, in
sage.graphs.planarity.is_planar
(/mnt/highperf/buildbot/slave/sage_git/build/src/build/cythonized/sage/graphs/planarity.c:1800)
g.relabel(ffrom)
File
"/mnt/highperf/buildbot/slave/sage_git/build/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 18006, in relabel
new_attr[perm[v]] = value
KeyError: 0
**********************************************************************
1 item had failures:
1 of 5 in sage.graphs.generators.random.RandomTriangulation
[71 tests, 1 failure, 5.56 s]
}}}
Would have been easy to catch if you had checked the patchbot output...
--
Ticket URL: <http://trac.sagemath.org/ticket/18860#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
