#18864: New method for the eccentricity of undirected graphs
-------------------------+-------------------------------------------------
Reporter: | Owner:
dcoudert | Status: positive_review
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: minor | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: David | 80cb89935d8eb8288d6659d7c73d8c05ee1c9411
Coudert | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18864 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by borassi):
* status: needs_review => positive_review
Comment:
Ok, for me now the patch is good to go.
I have run the doctest for the whole Sage, and I got an error, but it is
probably not related to this ticket.
{{{
sage -t --long src/sage/interfaces/expect.py
**********************************************************************
File "src/sage/interfaces/expect.py", line 825, in
sage.interfaces.expect.Expect._eval_line
Failed example:
singular.interrupt(timeout=3) # sometimes very slow (up to 60s on
sage.math, 2012)
Expected:
False
Got:
True
**********************************************************************
}}}
Indeed, I run again the same doctest and it worked.
Last thing: if you have time, you just wrote
{{{
if LB[w]==UB[w]:
continue
elif ...
do something
}}}
Maybe it is better to write
{{{
if LB[w]==UB[w] and (...):
do something
}}}
Anyway, I think you can also leave it as it is.
Thank you very much, David!
--
Ticket URL: <http://trac.sagemath.org/ticket/18864#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
