#18864: New method for the eccentricity of undirected graphs
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  dcoudert               |       Status:  positive_review
           Type:         |    Milestone:  sage-6.8
  enhancement            |   Resolution:
       Priority:  minor  |    Merged in:
      Component:  graph  |    Reviewers:  Michele Borassi
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:  David  |  80cb89935d8eb8288d6659d7c73d8c05ee1c9411
  Coudert                |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/18864           |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by dcoudert):

 * reviewer:   => Michele Borassi


Comment:

 Thanks for the review.
 I have added your name as a reviewer (mandatory).

 When `LB[w]==UB[w]`, we don't want to change `next_v`. So the `continue`
 statement seems appropriate. The alternative is to have `if LB[w]!=UB[w]
 and (next_v==UINT32_MAX or (cpt%2==0 and LB[w]<LB[next_v]) or (cpt%2==1
 and UB[w]>UB[next_v])):` which is harder to read.

--
Ticket URL: <http://trac.sagemath.org/ticket/18864#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to