#18904: Automatically test optional non-packages (CPLEX, Gurobi, Maple?, ..)
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
doctest framework | Work issues:
Keywords: | Commit:
Authors: | 44dd24195f94413afd072ef20d03d5491b8b5f2d
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18904 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
> Is the doctest controller responsible for third-party interfaces?
Where else do you expect to see the code which decides which third-party
interfaces should be tested? Are third-party interfaces responsible for
doctesting? Be serious.
> E.g. page 34 of
http://vitoex.googlecode.com/svn/trunk/Read/Clean%20Code.pdf recommends:
>
> "The first rule of functions is that they should be small. The second
rule of functions is that
> they should be smaller than that. [...] Functions should not be 100
lines long. Functions should hardly ever be 20 lines long."
That a fortunate coincidence, for my function has around 26 lines of code
(the rest is documentation). So I pass this test. Shoud I write myself to
sage-devel to ask whether we should enforce a hard line limit of 20 lines
per function?
The other good news for me is that I do not see anything about creating a
new file for functions of 20< x < 30 lines.
So it's still up for review.
I think that you are officially splitting hairs.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18904#comment:49>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
