#18395: (moderate) Speedup in layout_spring
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_work
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | 73662a95fb6e58805aa149f039f4c5b925785104
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18395 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by dcoudert):
* cc: dcoudert (added)
* status: needs_review => needs_work
Comment:
some problems remain :(
{{{
sage -t --long src/sage/graphs/generic_graph_pyx.pyx
**********************************************************************
File "src/sage/graphs/generic_graph_pyx.pyx", line 54, in
sage.graphs.generic_graph_pyx.spring_layout_fast_split
Failed example:
spring_layout_fast_split(G)
Expected:
{0: [0.452..., 0.247...], ..., 502: [25.7..., 0.505...]}
Got:
{0: [0.7785109925614286, 0.06976708739098784],
1: [0.7761449200341834, 0.5516862310233024],
...
902: [3.130511551759616, 0.22735834286143738]}
**********************************************************************
File "src/sage/graphs/generic_graph_pyx.pyx", line 97, in
sage.graphs.generic_graph_pyx.spring_layout_fast
Failed example:
spring_layout_fast(G)
Expected:
{0: [-0.0733..., 0.157...], ..., 502: [-0.551..., 0.682...]}
Got:
{0: [0.007496865679470362, 0.04129113197411667],
1: [0.01495366592880235, 0.08850535412927439],
2: [0.05849657218327249, 0.09484847570321614],
...
901: [-0.4474352390771702, -0.10570013179405174],
902: [-0.47861195812354, -0.10660577880837746]}
**********************************************************************
File "src/sage/graphs/generic_graph_pyx.pyx", line 113, in
sage.graphs.generic_graph_pyx.spring_layout_fast
Failed example:
spring_layout_fast(G, by_component = True)
Expected:
{0: [2.12..., -0.321...], ..., 502: [26.0..., -0.812...]}
Got:
{0: [2.2186445972355, -0.008574741789712105],
1: [2.121454111190332, 0.5076017939042802],
...
902: [3.0706796988471234, 0.8610997979963941]}
**********************************************************************
File "src/sage/graphs/generic_graph_pyx.pyx", line 348, in
sage.graphs.generic_graph_pyx.sqrt_approx
Failed example:
polar_plot([1,lambda x:dist(cos(x),sin(x))], (0, 2*pi))
Expected:
Launched png viewer for Graphics object consisting of 2 graphics
primitives
Got:
Graphics object consisting of 2 graphics primitives
**********************************************************************
3 items had failures:
2 of 9 in sage.graphs.generic_graph_pyx.spring_layout_fast
1 of 5 in sage.graphs.generic_graph_pyx.spring_layout_fast_split
1 of 3 in sage.graphs.generic_graph_pyx.sqrt_approx
[81 tests, 4 failures, 3.42 s]
----------------------------------------------------------------------
sage -t --long src/sage/graphs/generic_graph_pyx.pyx # 4 doctests failed
----------------------------------------------------------------------
Total time for all tests: 3.5 seconds
cpu time: 3.2 seconds
cumulative wall time: 3.4 seconds
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/18395#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
