#6648: [with patch, needs work] adds riemann mapping and complex interpolation
-------------------------+--------------------------------------------------
Reporter: evanandel | Owner: evanandel
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.1.2
Component: calculus | Keywords: complex
Reviewer: | Author: Ethan Van Andel
Merged: |
-------------------------+--------------------------------------------------
Comment(by mvngu):
I assume that patches should be merged in this order:
1. `12659.5.patch`
1. `12660.patch`
These patches apply OK against Sage 4.1.1, with `12660.patch` resulting in
some fuzz:
{{{
[mv...@sage sage-main]$ hg qimport http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/6648/12660.patch && hg qpush
adding 12660.patch to series file
applying 12660.patch
patching file module_list.py
Hunk #1 succeeded at 125 with fuzz 2 (offset 8 lines).
patching file sage/calculus/all.py
Hunk #1 succeeded at 20 with fuzz 2 (offset 4 lines).
Now at: 12660.patch
}}}
Don't worry about the fuzz. However, building the reference manual results
in 17 warnings:
{{{
WARNING: <autodoc>:0: (ERROR/3) Unexpected indentation.
WARNING: <autodoc>:0: (ERROR/3) Unexpected indentation.
WARNING: <autodoc>:0: (ERROR/3) Unexpected indentation.
WARNING: <autodoc>:0: (ERROR/3) Unexpected indentation.
WARNING: :0: (ERROR/3) Unexpected indentation.
WARNING: :0: (ERROR/3) Unexpected indentation.
WARNING: /scratch/mvngu/release/sage-4.1.1/local/lib/python2.6/site-
packages/sage/calculus/riemann.so:docstring of sage.calculus.riemann:3:
(ERROR/3) Unexpected indentation.
WARNING: <autodoc>:0: (ERROR/3) Unexpected indentation.
WARNING: /scratch/mvngu/release/sage-4.1.1/local/lib/python2.6/site-
packages/sage/calculus/riemann.so:docstring of sage.calculus.riemann:5:
(ERROR/3) Unexpected indentation.
WARNING: <autodoc>:0: (ERROR/3) Unexpected indentation.
WARNING: <autodoc>:0: (ERROR/3) Unexpected indentation.
WARNING: /scratch/mvngu/release/sage-4.1.1/local/lib/python2.6/site-
packages/sage/calculus/riemann.so:docstring of sage.calculus.riemann:3:
(ERROR/3) Unexpected indentation.
WARNING: <autodoc>:0: (ERROR/3) Unexpected indentation.
WARNING: /scratch/mvngu/release/sage-4.1.1/local/lib/python2.6/site-
packages/sage/calculus/riemann.so:docstring of sage.calculus.riemann:5:
(ERROR/3) Unexpected indentation.
WARNING: <autodoc>:0: (ERROR/3) Unexpected indentation.
WARNING: /scratch/mvngu/release/sage-4.1.1/local/lib/python2.6/site-
packages/sage/calculus/riemann.so:docstring of
sage.calculus.riemann.ColorPlot.get_minmax_data:5: (ERROR/3) Unexpected
indentation.
WARNING: <autodoc>:0: (ERROR/3) Unexpected indentation.
pickling environment... done
checking consistency... done
preparing documents... done
writing output... calculus index sage/calculus/interpolators
sage/calculus/riemann
writing additional files... genindex modindex search
copying static files... done
dumping search index... done
dumping object inventory... done
build succeeded, 17 warnings.
}}}
Two crucial doctests are missing:
{{{
[mv...@sage sage-4.1.1]$ ./sage -coverage devel/sage-
main/sage/calculus/interpolators.pyx
----------------------------------------------------------------------
devel/sage-main/sage/calculus/interpolators.pyx
ERROR: Please define a s == loads(dumps(s)) doctest.
SCORE devel/sage-main/sage/calculus/interpolators.pyx: 100% (8 of 8)
----------------------------------------------------------------------
[mv...@sage sage-4.1.1]$ ./sage -coverage devel/sage-
main/sage/calculus/riemann.pyx
----------------------------------------------------------------------
devel/sage-main/sage/calculus/riemann.pyx
ERROR: Please define a s == loads(dumps(s)) doctest.
SCORE devel/sage-main/sage/calculus/riemann.pyx: 100% (14 of 14)
Possibly wrong (function name doesn't occur in doctests):
* _render_on_subplot(self, subplot):
----------------------------------------------------------------------
}}}
And I get some doctest failure, which are mostly numerical noise:
{{{
sage -t -long devel/sage-main/sage/calculus/riemann.pyx
**********************************************************************
File "/scratch/mvngu/release/sage-4.1.1/devel/sage-
main/sage/calculus/riemann.pyx", line 459:
sage: m.inverse_riemann_map(.95) #long time
Expected:
(0.486319431795...-4.90019052414...e-06j)
Got:
(0.48631943179594372-4.9001905240969853e-06j)
**********************************************************************
File "/scratch/mvngu/release/sage-4.1.1/devel/sage-
main/sage/calculus/riemann.pyx", line 394:
sage: m.riemann_map(1.3*I) #long time
Expected:
(-1.56102939636...e-05+0.989694535737...j)
Got:
(-1.5610293963970239e-05+0.98969453573774413j)
**********************************************************************
File "/scratch/mvngu/release/sage-4.1.1/devel/sage-
main/sage/calculus/riemann.pyx", line 398:
sage: m.riemann_map(.4) #long time
Expected:
(0.733242677182...+3.50767714620...e-06j)
Got:
(0.73324267718245462+3.5076771462558728e-06j)
**********************************************************************
File "/scratch/mvngu/release/sage-4.1.1/devel/sage-
main/sage/calculus/riemann.pyx", line 402:
sage: m.riemann_map(np.complex(-3,.0001)) #long time
Expected:
(1.40575713549...e-05+1.05106170694...e-09j)
Got:
(1.4057571354958779e-05+1.0510616458088591e-09j)
**********************************************************************
2 items had failures:
1 of 8 in __main__.example_10
3 of 9 in __main__.example_8
***Test Failed*** 4 failures.
For whitespace errors, see the file
/scratch/mvngu/release/sage-4.1.1/tmp/.doctest_riemann.py
[76.3 s]
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6648#comment:21>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
