#18860: Faster Poyhedron.graph()
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Dima Pasechnik
geometry | Work issues:
Keywords: | Commit:
Authors: | 5223cda9f15b2a417b550039b978a07e126f9053
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18860 |
Dependencies: |
#18779 |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Oh, no problem: there is a difference between the previous output or
`.vertex_graph` and the new version: in the former, the vertices of the
graph were labelled on integers. Now, the vertices of that graph are the
'vertex' objects contained in the polyhedron.
I adapted the code, for it expected the keys of the position dictionary
(the vertices) to be integers, instead of the new points.
Actually, it convinced me that the previous version of this function was
incorrect in theory. It was assumed that the vertices of the polyhedron
appeared in the very same order as how they were first given to the
polyhedron constructor. I don't know if it is true in practice, but for
sure there is no reason to assume that a priori. So you can see this as a
bugfix `;-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18860#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
