#17462: Remove the (deprecated) _boundary parameter
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-pending
defect | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | 41943ff9a08e086a14f2bf4d897bac60321288c1
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/17462 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by dcoudert):
Long tests ok for `graph.py`, `digraph.py` and `graph_plot.py`, but not
for `generic_graph.py`.
{{{
sage -t --long src/sage/graphs/generic_graph.py
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 1999, in
sage.graphs.generic_graph.GenericGraph.get_embedding
Failed example:
G.genus()
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest
sage.graphs.generic_graph.GenericGraph.get_embedding[1]>", line 1, in
<module>
G.genus()
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 2001, in
sage.graphs.generic_graph.GenericGraph.get_embedding
Failed example:
G.get_embedding()
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest
sage.graphs.generic_graph.GenericGraph.get_embedding[2]>", line 1, in
<module>
G.get_embedding()
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 2007, in get_embedding
raise ValueError('%s has been modified and the embedding is no
longer valid'%self)
ValueError: Petersen graph has been modified and the embedding is no
longer valid
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 3823, in
sage.graphs.generic_graph.GenericGraph.is_planar
Failed example:
g.is_planar(on_embedding=emb)
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest
sage.graphs.generic_graph.GenericGraph.is_planar[26]>", line 1, in
<module>
g.is_planar(on_embedding=emb)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 3834, in is_planar
return (0 ==
self.genus(minimal=False,set_embedding=False,on_embedding=on_embedding))
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4280, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
g.genus() # tests for minimal genus by default
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[1]>",
line 1, in <module>
g.genus() # tests for minimal genus by default
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4282, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
g.genus(on_embedding=True, maximal=True) # on_embedding overrides
minimal and maximal arguments
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[2]>",
line 1, in <module>
g.genus(on_embedding=True, maximal=True) # on_embedding overrides
minimal and maximal arguments
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4284, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
g.genus(maximal=True) # setting maximal to True overrides default
minimal=True
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[3]>",
line 1, in <module>
g.genus(maximal=True) # setting maximal to True overrides default
minimal=True
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4286, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
g.genus(on_embedding=g.get_embedding()) # can also send a valid
combinatorial embedding dict
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[4]>",
line 1, in <module>
g.genus(on_embedding=g.get_embedding()) # can also send a valid
combinatorial embedding dict
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 2007, in get_embedding
raise ValueError('%s has been modified and the embedding is no
longer valid'%self)
ValueError: Petersen graph has been modified and the embedding is no
longer valid
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4288, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
(graphs.CubeGraph(3)).genus()
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[5]>",
line 1, in <module>
(graphs.CubeGraph(Integer(3))).genus()
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4291, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
K23.genus()
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[7]>",
line 1, in <module>
K23.genus()
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4294, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
K33.genus()
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[9]>",
line 1, in <module>
K33.genus()
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4321, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
G.genus()
Expected:
Traceback (most recent call last):
...
NotImplementedError: Can't work with embeddings of non-simple graphs
Got:
<BLANKLINE>
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[17]>",
line 1, in <module>
G.genus()
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4325, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
G.to_simple().genus()
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[18]>",
line 1, in <module>
G.to_simple().genus()
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4327, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
G.genus(set_embedding=False)
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[19]>",
line 1, in <module>
G.genus(set_embedding=False)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4329, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
G.genus(maximal=True, set_embedding=False)
Expected:
Traceback (most recent call last):
...
NotImplementedError: Can't compute the maximal genus of a graph with
loops or multiple edges
Got:
<BLANKLINE>
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[20]>",
line 1, in <module>
G.genus(maximal=True, set_embedding=False)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 4346, in
sage.graphs.generic_graph.GenericGraph.genus
Failed example:
G.genus()
Exception raised:
Traceback (most recent call last):
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 496, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 858, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.genus[25]>",
line 1, in <module>
G.genus()
File "/Users/dcoudert/sage/local/lib/python2.7/site-
packages/sage/graphs/generic_graph.py", line 4362, in genus
raise ValueError("'circular' is expected to be a list")
ValueError: 'circular' is expected to be a list
**********************************************************************
3 items had failures:
12 of 27 in sage.graphs.generic_graph.GenericGraph.genus
2 of 4 in sage.graphs.generic_graph.GenericGraph.get_embedding
1 of 28 in sage.graphs.generic_graph.GenericGraph.is_planar
[2690 tests, 15 failures, 63.86 s]
----------------------------------------------------------------------
sage -t --long src/sage/graphs/generic_graph.py # 15 doctests failed
----------------------------------------------------------------------
Total time for all tests: 64.4 seconds
cpu time: 45.2 seconds
cumulative wall time: 63.9 seconds
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/17462#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
