#17462: Remove the (deprecated) _boundary parameter
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-pending
defect | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | 43cf74ac4b0bb2729ffe7288d8d1ab4ed8e76a8d
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dcoudert/17462 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by dcoudert):
* commit: 43bb53f2d5e98c58d571695dd797f858ad2f96ae =>
43cf74ac4b0bb2729ffe7288d8d1ab4ed8e76a8d
Comment:
Hello,
I did small modifications, but I'm not good for pushing commits and so all
is in a new branch. Sorry for that.
I did only the following modifications:
- in both files `graph.py` and `digraph.py`, remove in the description of
the class parameters
{{{
- ``boundary`` - a list of boundary vertices, if
empty, digraph is considered as a 'graph without boundary'
}}}
- and remove `boundary=None` in
{{{
def __init__(self, data=None, pos=None, loops=None, format=None,
boundary=None, weighted=None, implementation='c_graph',
data_structure="sparse", vertex_labels=True, name=None,
multiedges=None, convert_empty_dict_labels_to_None=None,
sparse=True, immutable=False):
}}}
- In file `generic_graph.py`, remove word `boundary` from the method
description
{{{
:meth:`~GenericGraph.clear` | Empty the graph of vertices and edges
and removes name, boundary, associated objects, and position information.
}}}
- and in
{{{
def clear(self):
"""
Empties the graph of vertices and edges and removes name,
boundary,
associated objects, and position information.
}}}
If you agree, you can set the ticket to positive review.
David.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=e1c00ebf86c2e34c0a952ff1755e87a1f6902685
e1c00eb]||{{{trac #17462: remove useless doc and parameter in graph.py and
digraph.py}}}||
||[http://git.sagemath.org/sage.git/commit/?id=43cf74ac4b0bb2729ffe7288d8d1ab4ed8e76a8d
43cf74a]||{{{trac #17462: clean doc in generic_graph.py}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17462#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
