#18948: Strongly Regular Graphs database
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_work
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Dima Pasechnik
theory | Work issues:
Keywords: | Commit:
Authors: | d1d25a03964f92c590449bebd359b21e7feaf349
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/18948 |
Dependencies: |
#18934 |
-------------------------+-------------------------------------------------
Comment (by dimpase):
Replying to [comment:54 ncohen]:
> > These commits should not affect the outcome, or at least I don't see
how they can.
>
> Easy: you add constructions of strongly regular graphs. The only thing
this doctest does is check the *COUNT* of them (note that the individual
lines naming each graph are not check, except the first, because of
'...'). Given that you add constructions, the final number changes, and
the doctest breaks.
Oh hell... How about we add a special tag (say, countexamples) to these
counting test(s), so that they don't normally run.
>
> > Or, if you like, I have weird test failures on my branch due to
something in your already reviewed tickets...
>
> Just load *ONLY* the branch, and you will not have any problem. If you
add other commits, now, I can do no magic.
The problem is that nobody expects the Spanish Inquisition hitting on your
tests this way. Doctesting such counts is akin to doctesting number of
Sage tests that pass...
--
Ticket URL: <http://trac.sagemath.org/ticket/18948#comment:57>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
