#17425: Rational isometry test for quadratic forms over number fields
-------------------------------------+-------------------------------------
Reporter: annahaensch | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.9
Component: quadratic forms | Resolution:
Keywords: | Merged in:
Authors: Anna Haensch | Reviewers: Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/annahaensch/ticket/17425 | 8972c8097f74e9bd8e393a839b7ff9e250476af7
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
With the current code there is something wrong going on. If the dimensions
are different then `Rat_Isom_flag` is set to `False`. This is fine. But
then it will try to multiply the Gram determinant (for nothing since we
already knew that they were not equivalent).
Similarly, in this loop
{{{
for p in L:
if self.hasse_invariant(p) != other.hasse_invariant(p):
Rat_Isom_flag = False
}}}
if you found out that something is wrong during the first pass you will
have to wait!
This is why I suggested to modify the code to
{{{
if bad behavior 1:
return False
if bad behavior 2:
return False
for i in some test case:
if bad behavior 3:
return False
return True
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/17425#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
