#17425: Rational isometry test for quadratic forms over number fields
-------------------------------------+-------------------------------------
Reporter: annahaensch | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: quadratic forms | Resolution:
Keywords: | Merged in:
Authors: Anna Haensch | Reviewers: Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/annahaensch/ticket/17425 | 8b2f1aa042fae06af40366d50d86b02e17d6e66e
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:12 vdelecroix]:
> Could you add some tests for all the cases (starting from the Gram
determinant being 0)?
You forgot this one. I would be happy with more specifications and
degenerate tests. For example, you can copy paste the following
{{{
TESTS:
The diagonal form must have the same base ring otherwise a
`TypeError` is raised::
sage: K1.<a> = QuadraticField(5)
sage: K2.<b> = QuadraticField(7)
sage: V = DiagonalQuadraticForm(K1,[1,a])
sage: W = DiagonalQuadraticForm(K2,[1,b])
sage: V.is_rationally_isometric(W)
Traceback (most recent call last):
...
TypeError: forms must have the same base ring.
}}}
Beyond that the code looks good to me. I am compiling the documentation
right now to see how it looks.
Replying to [comment:14 annahaensch]:
> There is a way to return the transformation, in fact I have a student
writing that as a separate function right now. I think it's best to keep
it separate from this function, since in principle, his functions work for
integral lattices as well, whereas this one is only applicable to fields.
Nevertheless, I suppose I should open a trac ticket for that...
Nice! He or she might open the ticket. That is part of the learning curve
;-)
--
Ticket URL: <http://trac.sagemath.org/ticket/17425#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
