#18586: passing on parameters and extra_category for cartesian products
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.9
Component: categories | Resolution:
Keywords: sd67 | Merged in:
Authors: Daniel Krenn | Reviewers: Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: u/dkrenn/cat | Commit:
/extra-category | ba5dab93e6c7b33eeefc0c937dd2a7d11098807a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:7 dkrenn]:
> Replying to [comment:6 vdelecroix]:
> > > > But what is the point of the ignored `flatten` argument and the
forbidden `kwargs` in `cartesian_product.py`??
> > Would it hurt to remove it?
>
> I wouldn't mind at all. I have not tested what happens if we do. ...but
someone introduced it, maybe this person has an opinion on it?
He might. He is Nicolas Thiéry in commit `c4629fde` from 2010. But that is
not the good way to go. We could add ignored parameters `a`, `b`, `c`, ...
they might be very useful in the future.
> > What about the `kwargs` that you added?
>
> They are not used in `sets.cartesian_product.CartesianProduct` but can
be used in a derived class (e.g. #18223).
Why not adding it in #18223 then? With this ticket we end up with two
arguments that are for future use. It is not an improvement.
--
Ticket URL: <http://trac.sagemath.org/ticket/18586#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
