#18959: Poset documentation polishing: integer-valued properties
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.9
      Component:  documentation      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:  Nathann Cohen
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/poset_documentation_polishing__integer_valued_properties|  
2b190b2de01c21578efefe5d876f83e330a12197
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * reviewer:   => Nathann Cohen


Comment:

 Hello !

 Two comments:

 - There is an 'Integer(0)' left
 - It is (slightly) better to have `# random` than `# not tested`: in the
 first case the command is not run, while in the second it is run and the
 output is not compared with the expected results (which would still report
 an error in case of an exception). Given the command in question ('sage:
 L') it hardly matters here

 Regardless of what you decide to do with those two points, you can set the
 ticket to `positive_review` on my behalf.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/18959#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to