#18959: Poset documentation polishing: integer-valued properties
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  minor              |    Milestone:  sage-6.9
      Component:  documentation      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:  Nathann Cohen
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/poset_documentation_polishing__integer_valued_properties|  
3302f91538b7258d2ad58d413c84a69e0308a53c
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jmantysalo):

 * status:  needs_review => positive_review


Old description:

> Check documentation in functions like `cardinality()`, `height()` and
> `dimension()`.
>
> This continues the series beginning with #18925 and #18941.

New description:

 Check documentation in functions like `cardinality()`, `height()` and
 `dimension()`.

 This continues the series beginning with #18925 and #18941.

 (Also adds input checking for `random_order_ideal()`.)

--

Comment:

 Replying to [comment:11 ncohen]:

 > - It is (slightly) better to have `# random` than `# not tested`: in the
 first case the command is not run - -

 True. Corrected.

 > - There is an 'Integer(0)' left

 > Regardless of what you decide to do with those two points, you can set
 the ticket to `positive_review` on my behalf.

 I would have said this a bug. I corrected it also.

 Thanks!

--
Ticket URL: <http://trac.sagemath.org/ticket/18959#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to