#19048: AsymptoticRing: an_element
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: sage-6.9
Component: symbolics | Resolution:
Keywords: asymptotics | Merged in:
Authors: Daniel Krenn | Reviewers: Benjamin Hackl
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/behackl/asy/an_element | 9c1fc0e5ae62f1fdfc59acea333ea9df9637e0b7
Dependencies: #17716, #19047 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by behackl):
* reviewer: => Benjamin Hackl
* branch: u/dkrenn/asy/an_element => u/behackl/asy/an_element
* commit: 4f294ce9023fc4908bb3ad67228f900111826158 =>
9c1fc0e5ae62f1fdfc59acea333ea9df9637e0b7
Comment:
I've reviewed your changes, merged the latest `asy/asymptoticExpression`
into this branch and applied a tiny reviewer's patch (somehow, `'exact`
was pasted where it definitely should not). In principal, everything looks
good to me and the doctests pass.
However, do you think that `asymptotic_term.py` really is the best place
for the `product_diagonal` function? I do understand that it is required
as a helper function there -- but nevertheless, from my point of view, the
function is sufficiently general so that it could also live, for example,
in `src/sage/misc/misc.py`.
What do you think?
----
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=43fd06d3ba8c57edd75262526c51ab89aabdf27a
43fd06d]||{{{delete stop-option from some_elements}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4f294ce9023fc4908bb3ad67228f900111826158
4f294ce]||{{{improve product_diagonal so that input is read only when
needed}}}||
||[http://git.sagemath.org/sage.git/commit/?id=186ecfc13db772e1b89ee09b10b7e220b6e9e307
186ecfc]||{{{simplified doctests: removed some unneccessary imports}}}||
||[http://git.sagemath.org/sage.git/commit/?id=aa4c6475fc892a8a6b4ca7f853af308e86e1812f
aa4c647]||{{{Merge branch 'u/dkrenn/asy/asymptoticExpression' into
asy/asymptoticExpression}}}||
||[http://git.sagemath.org/sage.git/commit/?id=5911564395f1741a514ba5c6a10c91ec252061ff
5911564]||{{{typo fixed and line break introduced}}}||
||[http://git.sagemath.org/sage.git/commit/?id=7aa3e6026848986767a16ead830755e64f1d41f9
7aa3e60]||{{{`QQ` --> `\mathbb{Q}`}}}||
||[http://git.sagemath.org/sage.git/commit/?id=3e2a7b30fc098fd12a092e44b651e667d81080e1
3e2a7b3]||{{{typo fixed}}}||
||[http://git.sagemath.org/sage.git/commit/?id=f11877232543a2d08b45f2a1924793ad129b7576
f118772]||{{{some SEEALSO-blocks added}}}||
||[http://git.sagemath.org/sage.git/commit/?id=9354773003b92d5071a401f1e0f96b075b3e625c
9354773]||{{{Merge branch 'asy/asymptoticExpression' into
asy/an_element}}}||
||[http://git.sagemath.org/sage.git/commit/?id=9c1fc0e5ae62f1fdfc59acea333ea9df9637e0b7
9c1fc0e]||{{{cleanup documentation: strange 'exact removed}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19048#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
