#19026: better matrix generic dense
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: linear algebra | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/19026 | 0a97b0359e7e60a25b63d00578afd55283717b61
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by mmezzarobba):
Some minor comments:
* ` _new_uninitialized_matrix` should probably be called `_new` (or
`_new_c`...), since these are the names most other `Elements` use
(including `Matrix_double_dense` — only `Matrix_integer_dense` calls this
method `_new_uninitialized_matrix`);
* `Matrix_generic_dense.__init__`: “we affect” should probably be “we
assign”
* (`Matrix_generic_dense.__init__`: I find the new logic a bit hard to
follow, but I didn't try to simplify it)
--
Ticket URL: <http://trac.sagemath.org/ticket/19026#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
