#18972: twographs and Seidel switching
-------------------------------------+-------------------------------------
Reporter: dimpase | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.9
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dimpase/seidelsw | 6bc5cbd678d6d9db6e99ff23489e0e1a720e8569
Dependencies: #18960, #18948, | Stopgaps:
#18988, #18991, #18986, #19018, |
#19019 |
-------------------------------------+-------------------------------------
Comment (by dimpase):
Replying to [comment:81 ncohen]:
> Here is another review. I also fixed a couple of things in a commit at
`public/18972`.
Thanks! Here are few clarifications/comments/questions:
> - The first letter of the docstrings should be in upper case. I told you
that
> already.
oops, sorry, I misunderstood your comment about this, and was making
things lower case...
>
> - There are still broken links. If you can't be bothered to read the
doc, at
> least compile it with `--warn-links`.
I normally build docs with make. Does it mean I better do an explicit
`-docbuild`?
>
> - `complement` -- the default meaning of `.complement()` is different on
> `IncidenceStructure` and on `TwoGraph`. Could you conform to the most
general
> specification?
no, for two-graphs it's the way it is. Should I rename this
`.complement()` as
`twograph_complement()`?
>
> - It feels a bit weird that the default behaviour of `seidel_switching`
is not
> to modify the graph inplace but to return a copy... I would have
expected a
> `inplace=False` argument for that.
well, I don't like inplace things. I don't even have an inplace option for
this function.
I hope it's OK.
I'm going to fix the rest and add a construction of two-graphs (more
precisely, certain Seidel adj.matrices, from which the two-graph can be
constructed, if needed) from doubly-transitive permutation groups, i.e.
Taylor two-graphs.
--
Ticket URL: <http://trac.sagemath.org/ticket/18972#comment:82>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
