#18972: twographs and Seidel switching
-------------------------------------+-------------------------------------
Reporter: dimpase | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.9
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dimpase/seidelsw | 68c0edd21e25d74df2bf41e060e9e55c99ca2fca
Dependencies: #18960, #18948, | Stopgaps:
#18988, #18991, #18986, #19018, |
#19019 |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Helloooo Dima,
Here is a first-pass review:
- Where exactly is the 'twograph' module to be found in the documentation?
It
does not belong to the main 'design' page.
- `is_regular_twograph` -- the first sentence of the docstring must be
short
(one line) and describe what the function does.
- doc of `descendant`: a sentence starts with an upper-case letter. Same
with
`complement()`, `twograph_descendant()`
- {{{``self.ground_set()``}}} -- should be a link.
- `is_twograph` -- you should rephrase the first sentence of the doc. An
INPUT
block is missing.
- Construction of chang graphs by switching: define K8 and T8 in the block
that
does that, not in the previous doc which does not use them.
- {{{:meth:`sage.matrix.change_ring`}}} -- broken link (appears twice)
- `seidel_matrix` INPUT for Graph: you must add doctests to test that it
works,
and to test your exceptions.
- {{{is_two_graph_descendant_of_srg}}} - what about those `v0,k0,l0,mu0`
we
already mentionned? `v,k,l,mu` would be easier to read.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18972#comment:74>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
