#18437: Switch from PolyBoRi to BRiAl
-------------------------------------+-------------------------------------
       Reporter:  ohanar             |        Owner:
           Type:  task               |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.8
      Component:  packages:          |   Resolution:
  standard                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  R. Andrew Ohana    |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/ohanar/brial     |  fdff73302359b87ab524b5a7f3722e36a550ca7f
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by fbissey):

 Do I understand well that `libgd` is looked for if `libpng` is not there?
 It is all a bit strange. If `m4ri` doesn't have support for `png` I guess
 `have_libpng` will be empty and then `libgd` will be checked. The line
 {{{
         AC_DEFINE([PBORI_HAVE_GD],[],[has gd png support])
 }}}
 is a bit misleading as if you arrive there, you have `libgd` support which
 may or may not have `png` included in it.

 Also why shouldn't the compilation abort if `m4ri_png=yes` but you cannot
 find `libpng`? As far as I can tell `m4ri` won't use `libgd` for libpng
 unless you abuse the configuration options, so that whole structure looks
 very strange.

 I guess on closer look I have an issue with the way m4ri/m4rie/polybory
 deal with some of their optional dependencies, and that may be something
 to look into in the future. For starter if `m4ri` is compiled with `png`
 support, the used `libpng` should be included in output of `pkg-config
 m4ri --libs`.

--
Ticket URL: <http://trac.sagemath.org/ticket/18437#comment:39>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to