#18720: Change diagram algebra basis set partitions from list to generator
-------------------------------------+-------------------------------------
Reporter: ghseeli | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.9
Component: algebra | Resolution:
Keywords: days65, partition | Merged in:
algebra, diagram algebra | Reviewers: Travis Scrimshaw
Authors: George H. | Work issues:
Seelinger | Commit:
Report Upstream: N/A | 616b818be77e7a7b45763b1d71d64f950061c5c0
Branch: | Stopgaps:
u/tscrim/diagram_algebra_improvements-18720|
Dependencies: #18707 |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_work => needs_review
* commit: c716ed1f04481f887151cee40dca441cecfc9daa =>
616b818be77e7a7b45763b1d71d64f950061c5c0
* branch: u/ghseeli/diagram_algebra_improvements-18720 =>
u/tscrim/diagram_algebra_improvements-18720
Comment:
I've fixed the failing doctest in `doctests/sources.py` (you needed to run
`--long` with it, something which I didn't know had changed). I've also
made some other documentation fixes, which I forgot needed to be done. I
also cleaned up the code to make it python3 compliant and might result in
a very marginal speedup. So if you're happy with my changes, then you can
set this back to positive review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=fa3f7926d3753a13f33200f22870507d870ff835
fa3f792]||{{{Fixed doctest in sources.py.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=616b818be77e7a7b45763b1d71d64f950061c5c0
616b818]||{{{Fixing the documentation and some code cleanup/python3
support.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18720#comment:60>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.